Include key size in ARGS_COMBINED_SIZE (#756)

Co-authored-by: José Carlos Chávez <[email protected]>
corazawaf · Apr 12, 2023 · 6f11f53 · 6f11f53
1 parent 57b42eb
commit 6f11f53
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/internal/collections/sized.go b/internal/collections/sized.go
@@ -73,7 +73,7 @@ func (c *SizeCollection) size() int {
 		// we iterate over d
 		for _, data := range d.data {
 			for _, v := range data {
-				i += len(v.value)
+				i += len(v.key) + len(v.value)
 			}
 		}
 	}

diff --git a/internal/collections/sized_test.go b/internal/collections/sized_test.go
@@ -19,18 +19,18 @@ func TestSizedCollection(t *testing.T) {
 		t.Errorf("want %s, have %s", want, have)
 	}
 	c1.Set("key1", []string{"value1", "value2"})
-	assertValuesMatch(t, proxy.FindAll(), "12")
-	if want, have := "ARGS_COMBINED_SIZE: 12", proxy.String(); want != have {
+	assertValuesMatch(t, proxy.FindAll(), "20")
+	if want, have := "ARGS_COMBINED_SIZE: 20", proxy.String(); want != have {
 		t.Errorf("want %s, have %s", want, have)
 	}
 	c1.Set("key2", []string{"value2"})
-	assertValuesMatch(t, proxy.FindAll(), "18")
-	if want, have := "ARGS_COMBINED_SIZE: 18", proxy.String(); want != have {
+	assertValuesMatch(t, proxy.FindAll(), "30")
+	if want, have := "ARGS_COMBINED_SIZE: 30", proxy.String(); want != have {
 		t.Errorf("want %s, have %s", want, have)
 	}
 	c2.Set("key3", []string{"value3"})
-	assertValuesMatch(t, proxy.FindAll(), "24")
-	if want, have := "ARGS_COMBINED_SIZE: 24", proxy.String(); want != have {
+	assertValuesMatch(t, proxy.FindAll(), "40")
+	if want, have := "ARGS_COMBINED_SIZE: 40", proxy.String(); want != have {
 		t.Errorf("want %s, have %s", want, have)
 	}
 }