Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial sign transactions *after* modifying them #4312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

steveluscher
Copy link
Contributor

In the event that the fee payer or the blockhash gets changed in prepareTransaction(), doing so will immediately invalidate the signatures made one block earlier. Sign as late as possible.

@steveluscher steveluscher force-pushed the correct-modify-sign-ordering branch from dbf9bb8 to ac668b6 Compare May 13, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant