[DOC][UI]: Fix issues on light/dark theme #3380
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: #3379
I used
"next-themes": "^0.4.3"
, https://ui.shadcn.com/docs/dark-mode/next to handle the shifting of light/dark themes.with
next-themes
, it can reduce much boilplate code to handle the changing of light/dark mode, and most importantly, it can easily get current theme, which will be used to control the theme of the code blockprism-react-renderer
in which it uses
github
theme for the code block by usingimport lightTheme from 'prism-react-renderer/themes/github'
, when in light mode.as an example:
also, after the fix. the scroll bar in dark mode looks better :