Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syn: Fix generic type aliases #2644

Merged

Conversation

acheroncrypto
Copy link
Collaborator

Problem

Generics are not supported with type aliases but they get included in the IDL regardless which cause client side problems.

Summary of changes

  • Don't include generic types in the IDL
  • Remove usage of unwrap on IdlType conversion, instead skip the types that return an error
  • Add a test case

@vercel
Copy link

vercel bot commented Oct 1, 2023

@acheroncrypto is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto added the idl related to the IDL, either program or client side label Oct 1, 2023
@acheroncrypto acheroncrypto merged commit e1d5e78 into coral-xyz:master Oct 1, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idl related to the IDL, either program or client side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant