Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): respond with "Hello, world!" #99

Merged
merged 1 commit into from
Sep 18, 2024
Merged

docs(examples): respond with "Hello, world!" #99

merged 1 commit into from
Sep 18, 2024

Conversation

francisfuzz
Copy link
Collaborator

What are you trying to accomplish?

This PR updates the example message we write back to the client with "Hello, world!" rather than a variant of my name. 😉

What approach did you choose and why?

One-liner change: targeted the text and updated it to match the file's intent.

What should reviewers focus on?

Nothing I haven't mentioned 😉

@francisfuzz francisfuzz self-assigned this Sep 17, 2024
@gr2m gr2m changed the title fix(examples): respond with "Hello, world!" docs(examples): respond with "Hello, world!" Sep 18, 2024
@gr2m
Copy link
Collaborator

gr2m commented Sep 18, 2024

fyi I changed the prefix from fix to docs because it's not a change in the module code, just in the example. It shouldn't trigger a new version or be listed in release notes

@gr2m gr2m merged commit 38e210f into main Sep 18, 2024
5 checks passed
@gr2m gr2m deleted the fast-follow-fix branch September 18, 2024 03:01
Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants