refactor: reuse createTextEvent() in createAckEvent()
#109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
approved these changes
Sep 20, 2024
gr2m
changed the title
createTextEvent() in createAckEvent()createTextEvent() in createAckEvent()
|
🎉 This PR is included in version 5.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
A refactoring opportunity: after reading
createAckEvent()andcreateTextEvent's definitions, I noticed that the only difference was that the former passes in an empty string for its content.What approach did you choose and why?
I chose to update the body to use
createTextEvent()directly, passing an empty string for itsmessageargument. Ran tests locally and in CI to verify this works 👍What should reviewers focus on?
Nothing I haven't mentioned 😉