This repository has been archived by the owner on Dec 22, 2022. It is now read-only.
Sourcery refactored master branch #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| @@ -2,6 +2,7 @@ | |||
| These are the default configuration options for Django-elRTE | |||
| """ | |||
|
|
|||
There was a problem hiding this comment.
Lines 25-51 refactored with the following changes:
- Replace interpolated string formatting with f-string [×7] (
replace-interpolation-with-fstring)
| 'cssfiles': ['%selrte-inner.css' % elrte.settings.CSS_BASE_URL], | ||
| 'cssfiles': [f'{elrte.settings.CSS_BASE_URL}elrte-inner.css'], |
There was a problem hiding this comment.
Lines 19-30 refactored with the following changes:
- Replace interpolated string formatting with f-string [×2] (
replace-interpolation-with-fstring)
This removes the following comments ( why? ):
# 'fmOpen': FileManagerOpener(),
Comment on lines
-71
to
+72
| html = [u'<textarea%s>%s</textarea>' % (flatatt(final_attrs), escape(value))] | ||
| html = [f'<textarea{flatatt(final_attrs)}>{escape(value)}</textarea>'] |
There was a problem hiding this comment.
Function ElrteTextareaWidget.render refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring)
Comment on lines
-94
to
+104
| if content_language: | ||
| content_language = content_language[:2] | ||
| else: | ||
| content_language = language | ||
|
|
||
| config = {} | ||
| config['language'] = language | ||
|
|
||
| content_language = content_language[:2] if content_language else language | ||
| config = {'language': language} | ||
| lang_names = SortedDict() | ||
| for lang, name in settings.LANGUAGES: | ||
| if lang[:2] not in lang_names: lang_names[lang[:2]] = [] | ||
| lang_names[lang[:2]].append(_(name)) | ||
| sp_langs = [] | ||
| for lang, names in lang_names.items(): | ||
| if lang == content_language: | ||
| default = '+' | ||
| else: | ||
| default = '' | ||
| sp_langs.append(u'%s%s=%s' % (default, ' / '.join(names), lang)) | ||
| default = '+' if lang == content_language else '' | ||
| sp_langs.append(f"{default}{' / '.join(names)}={lang}") |
There was a problem hiding this comment.
Function get_language_config refactored with the following changes:
- Replace if statement with if expression [×2] (
assign-if-exp) - Merge dictionary assignment with declaration (
merge-dict-assign) - Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!