Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for chaining setups, by storing the setups in an intermediary #77

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

bendiknesbo
Copy link
Contributor

@bendiknesbo bendiknesbo commented Dec 31, 2023

Contains breaking changes to the API, but hopefully not to any usages.

Will set labels on the PR to minor, and commit this breaking change as allowed during v0.

…ntermediary

Contains breaking changes to the API, but hopefully not to any usages
@bendiknesbo bendiknesbo marked this pull request as ready for review January 19, 2024 14:24
logger.go Show resolved Hide resolved
@bendiknesbo bendiknesbo changed the title feat!: add support for chaining setups, by storing the setups in an intermediary feat: add support for chaining setups, by storing the setups in an intermediary Jan 22, 2024
@github-actions github-actions bot added the major label Jan 22, 2024
@nhhagen
Copy link
Member

nhhagen commented Jan 22, 2024

great, the automation re-adds it, @arunpoudel can you help

@arunpoudel arunpoudel removed the major label Jan 22, 2024
@arunpoudel
Copy link
Contributor

@nhhagen Try now.

@arunpoudel arunpoudel self-requested a review January 22, 2024 12:58
@nhhagen
Copy link
Member

nhhagen commented Jan 22, 2024

@arunpoudel it still things 1.0.0 is the next release: https://github.com/coopnorge/go-logger/releases, but that is caused by #79

How do we resolve that

@arunpoudel
Copy link
Contributor

A temporary solution for now is to remove the label and re-run release drafter from main branch.

@arunpoudel
Copy link
Contributor

@nhhagen @bendiknesbo Done.

I will check if we have some time to namespace our labels this tech-debt day.

@bendiknesbo
Copy link
Contributor Author

bendiknesbo commented Jan 22, 2024

I re-ran the release drafter on main(https://github.com/coopnorge/go-logger/actions/runs/7572685129), and now the next version is v0.6.1, as expected.
Merging this PR will make the next version v0.7.0, since it's tagged as minor

@bendiknesbo
Copy link
Contributor Author

@nhhagen @bendiknesbo Done.

I will check if we have some time to namespace our labels this tech-debt day.

Great!

@bendiknesbo bendiknesbo enabled auto-merge (squash) January 22, 2024 13:10
@arunpoudel
Copy link
Contributor

@bendiknesbo Yes, that is how it will work. But if you want to keep the same minor version number, remove minor label, and it will treat it as a patch.

@bendiknesbo
Copy link
Contributor Author

This PR should be a minor-version bump, so I'll leave the minor label

@bendiknesbo bendiknesbo requested a review from nhhagen January 22, 2024 13:19
@bendiknesbo bendiknesbo merged commit e7a149a into main Jan 22, 2024
11 checks passed
@bendiknesbo bendiknesbo deleted the pov/v1-logrus branch January 22, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants