Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a Datadog logging adapter #100

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

nhhagen
Copy link
Member

@nhhagen nhhagen commented Apr 23, 2024

github.com/coopnorge/go-logger/adapter/datadog provides a simple logging
adapter for Datadog to ensure that logs from Datadog are properly
formatted by go-logger before ingestion into Datadog.

adapter/datadog/logger.go Outdated Show resolved Hide resolved
@nhhagen nhhagen marked this pull request as draft April 23, 2024 19:07
auto-merge was automatically disabled April 23, 2024 19:07

Pull request was converted to draft

@nhhagen nhhagen force-pushed the datadog-logger-2024-04-23-20-43-08 branch from da32632 to a141b5e Compare April 23, 2024 19:17
@nhhagen nhhagen marked this pull request as ready for review April 23, 2024 19:17
@nhhagen nhhagen force-pushed the datadog-logger-2024-04-23-20-43-08 branch 2 times, most recently from a75876e to 88fd498 Compare April 23, 2024 19:30
@nhhagen nhhagen force-pushed the datadog-logger-2024-04-23-20-43-08 branch from 88fd498 to a85225f Compare April 23, 2024 20:19
arunpoudel
arunpoudel previously approved these changes Apr 23, 2024
README.md Outdated Show resolved Hide resolved
adapter/datadog/logger.go Outdated Show resolved Hide resolved
adapter/datadog/logger_test.go Outdated Show resolved Hide resolved
@nhhagen nhhagen force-pushed the datadog-logger-2024-04-23-20-43-08 branch from a85225f to babcce3 Compare April 24, 2024 06:56
@nhhagen nhhagen force-pushed the datadog-logger-2024-04-23-20-43-08 branch from babcce3 to bdc0431 Compare April 24, 2024 06:57
@nhhagen nhhagen force-pushed the datadog-logger-2024-04-23-20-43-08 branch 8 times, most recently from f859e53 to bded04f Compare April 24, 2024 07:53
@nhhagen nhhagen marked this pull request as ready for review April 24, 2024 07:59
arunpoudel
arunpoudel previously approved these changes Apr 24, 2024
bendiknesbo
bendiknesbo previously approved these changes Apr 24, 2024
Copy link
Contributor

@bendiknesbo bendiknesbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. One nitpick that is not a blocker for merging.

LGTM

adapter/datadog/logger_test.go Outdated Show resolved Hide resolved
@nhhagen nhhagen dismissed stale reviews from bendiknesbo and arunpoudel via 7e9aba9 April 24, 2024 11:12
@nhhagen nhhagen force-pushed the datadog-logger-2024-04-23-20-43-08 branch from bded04f to 7e9aba9 Compare April 24, 2024 11:12
arunpoudel
arunpoudel previously approved these changes Apr 24, 2024
@nhhagen nhhagen force-pushed the datadog-logger-2024-04-23-20-43-08 branch from 7e9aba9 to ca88e39 Compare April 24, 2024 11:23
arunpoudel
arunpoudel previously approved these changes Apr 24, 2024
github.com/coopnorge/go-logger/adapter/datadog provides a simple logging
adapter for Datadog to ensure that logs from Datadog are properly
formatted by go-logger before ingestion into Datadog.
@nhhagen nhhagen force-pushed the datadog-logger-2024-04-23-20-43-08 branch from ca88e39 to 313c726 Compare April 24, 2024 11:37
Copy link
Contributor

@bendiknesbo bendiknesbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nhhagen nhhagen merged commit a9aea4b into main Apr 24, 2024
7 checks passed
@nhhagen nhhagen deleted the datadog-logger-2024-04-23-20-43-08 branch April 24, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants