-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a Datadog logging adapter #100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
policy-bot-coop-norge
bot
requested review from
arunpoudel,
AtzeDeVries,
bendiknesbo,
JEHCoop,
karkinissan,
misund,
sachinchauhan23 and
tuhtah
April 23, 2024 18:58
nhhagen
force-pushed
the
datadog-logger-2024-04-23-20-43-08
branch
2 times, most recently
from
April 23, 2024 19:03
a8d00d4
to
da32632
Compare
nhhagen
commented
Apr 23, 2024
auto-merge was automatically disabled
April 23, 2024 19:07
Pull request was converted to draft
nhhagen
force-pushed
the
datadog-logger-2024-04-23-20-43-08
branch
from
April 23, 2024 19:17
da32632
to
a141b5e
Compare
nhhagen
force-pushed
the
datadog-logger-2024-04-23-20-43-08
branch
2 times, most recently
from
April 23, 2024 19:30
a75876e
to
88fd498
Compare
nhhagen
force-pushed
the
datadog-logger-2024-04-23-20-43-08
branch
from
April 23, 2024 20:19
88fd498
to
a85225f
Compare
arunpoudel
previously approved these changes
Apr 23, 2024
bendiknesbo
reviewed
Apr 24, 2024
nhhagen
force-pushed
the
datadog-logger-2024-04-23-20-43-08
branch
from
April 24, 2024 06:56
a85225f
to
babcce3
Compare
nhhagen
force-pushed
the
datadog-logger-2024-04-23-20-43-08
branch
from
April 24, 2024 06:57
babcce3
to
bdc0431
Compare
nhhagen
force-pushed
the
datadog-logger-2024-04-23-20-43-08
branch
8 times, most recently
from
April 24, 2024 07:53
f859e53
to
bded04f
Compare
arunpoudel
previously approved these changes
Apr 24, 2024
bendiknesbo
previously approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good. One nitpick that is not a blocker for merging.
LGTM
bendiknesbo
reviewed
Apr 24, 2024
nhhagen
force-pushed
the
datadog-logger-2024-04-23-20-43-08
branch
from
April 24, 2024 11:12
bded04f
to
7e9aba9
Compare
arunpoudel
previously approved these changes
Apr 24, 2024
nhhagen
force-pushed
the
datadog-logger-2024-04-23-20-43-08
branch
from
April 24, 2024 11:23
7e9aba9
to
ca88e39
Compare
arunpoudel
previously approved these changes
Apr 24, 2024
github.com/coopnorge/go-logger/adapter/datadog provides a simple logging adapter for Datadog to ensure that logs from Datadog are properly formatted by go-logger before ingestion into Datadog.
nhhagen
force-pushed
the
datadog-logger-2024-04-23-20-43-08
branch
from
April 24, 2024 11:37
ca88e39
to
313c726
Compare
bendiknesbo
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
arunpoudel
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/coopnorge/go-logger/adapter/datadog provides a simple logging
adapter for Datadog to ensure that logs from Datadog are properly
formatted by go-logger before ingestion into Datadog.