feat: auto detect connectiontype #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preview PR for a simple attempt to detect connection socket type. This will not break the current API. * tests are not added yet. fixes: #423
AtzeDeVries
changed the title
policy-bot-coop-norge
bot
requested review from
andreasaaro,
Anwesha24,
CRCOOP,
irenemjs,
misund,
msporshe,
skasti and
yurydavydov
hawi74
previously approved these changes
Nov 12, 2024
nhhagen
reviewed
Nov 12, 2024
hawi74
previously approved these changes
Nov 14, 2024
hawi74
reviewed
Nov 14, 2024
Co-authored-by: Filip Stawicki <[email protected]>
bendiknesbo
reviewed
Nov 14, 2024
hadrienk
reviewed
Nov 14, 2024
I dont think a connectionType is used for DSD |
hawi74
approved these changes
Nov 14, 2024
bendiknesbo
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #423
Tests need to be added.Looking for some input on if this is a valid idea.