feat: Allow Datadog integration to be disabled #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhhagen
force-pushed
the
is-datadog-enabled-2024-03-18-23-10-05
branch
4 times, most recently
from
7ff40c3 to
5650ffd
Compare
nhhagen
force-pushed
the
is-datadog-enabled-2024-03-18-23-10-05
branch
6 times, most recently
from
7c6254c to
4107e0a
Compare
policy-bot-coop-norge
bot
requested review from
bendiknesbo,
eriken,
JEHCoop,
jonesmabea,
LinMAD,
tigertore,
tuhtah and
yogsothoth
nhhagen
force-pushed
the
is-datadog-enabled-2024-03-18-23-10-05
branch
from
4107e0a to
0a15fcc
Compare
bendiknesbo
reviewed
Apr 2, 2024
LinMAD
requested changes
Apr 2, 2024
@LinMAD The environment variable allows for deliberate control over the library rather than relying on "bad" configuration. This is valuable in testing to that you can disable the lib in a clear way and in production so that bad configuration causes an error and not a silent failure. |
nhhagen
force-pushed
the
is-datadog-enabled-2024-03-18-23-10-05
branch
from
ba73ff6 to
a470ff1
Compare
Use a flag to determine if Datadog should be disabled using a flag rather than relying on bad configuration. This removes the need to check for bad configuration before starting Datadog in services. Closes: #306
nhhagen
force-pushed
the
is-datadog-enabled-2024-03-18-23-10-05
branch
from
ef5e90a to
8b70a80
Compare
LinMAD
reviewed
Apr 2, 2024
nhhagen
force-pushed
the
is-datadog-enabled-2024-03-18-23-10-05
branch
from
45c34d8 to
39e0abe
Compare
bendiknesbo
approved these changes
Apr 3, 2024
|
@LinMAD waiting for you here |
LinMAD
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a flag to determine if Datadog should be disabled using a flag rather than
relying on bad configuration.
This removes the need to check for bad configuration before starting Datadog in
services.
Closes: #306