Run tests with mysql:8.0 and drop support for Ruby < 3.0 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you planning to deprecate support for using Barbeque (as OSS) with MySQL 5.7? This is just to confirm, and I think it's reasonable since MySQL 5.7 has reached its end of life. |
and drop support for MySQL 5.7
Yes. I added a statement of deprecation in CHANGELOG e415f14 |
coord-e
changed the title
|
Dropped Ruby < 3.0 support to deal with CI failures b69e38d |
hfm
approved these changes
Apr 12, 2024
nekketsuuu
approved these changes
Apr 12, 2024
mozamimy
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to upgrade our Barbeque deployment to use MySQL 8.0-compatible database cluster. This PR updates MySQL version used in CI to prepare for that. I confirmed specs passing locally with MySQL 8.0.
@cookpad/infra could you please review?