fix(respose): fix multiplying response body

cookielab · Apr 11, 2024 · ce2db8e · ce2db8e
1 parent d8d0c1d
commit ce2db8e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/logger.go b/logger.go
@@ -118,7 +118,6 @@ func (p *logRequest) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	defer resp.Flush()
 
 	respBodyBytes := resp.buf.Bytes()
-	_, _ = w.Write(respBodyBytes)
 
 	headers := make(map[string]string)
 	for name, values := range r.Header {

diff --git a/logger_test.go b/logger_test.go
@@ -39,6 +39,7 @@ func TestGetPlaintext(t *testing.T) {
 	handler.ServeHTTP(recorder, req)
 
 	assertHeaderExists(t, req)
+	assertBody(t, recorder, "helloWorld")
 }
 
 func TestGetJson(t *testing.T) {
@@ -241,6 +242,14 @@ func assertHeaderExists(t *testing.T, req *http.Request) {
 	}
 }
 
+func assertBody(t *testing.T, recorder *httptest.ResponseRecorder, expected string) {
+	t.Helper()
+
+	if recorder.Body.String() != expected {
+		t.Errorf("invalid body value: %s, expected %s", recorder.Body.String(), expected)
+	}
+}
+
 func prepareConfig(contentTypes []string, maxBodySize int, statusCodes []int) *traefikmiddlewarerequestlogger.Config {
 	cfg := traefikmiddlewarerequestlogger.CreateConfig()
 	cfg.ContentTypes = contentTypes