-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cxl-ui): [cxl-marketing-nav] allow menu to use full height after reposition #279
base: master
Are you sure you want to change the base?
Conversation
size-limit report 📦
|
Thanks. It's difficult to tell for QA where to look for before / after states. Can you edit PR opener with screenshots? |
@lkraav I'm not sure why, though I'm not able to replicate in Storybook. In Storybook This isn't ideal, though I'm not sure how to replicate this in Storybook. |
Maybe it's some race condition, and not a safe solution? Still, intended result before / after screenshots are needed for reviewers to evaluate anything, even if "after" is with manual inspector modding right now. |
I added screenshots earlier, though didn't click update comment :/ They should be there now. |
Hmm, but this is on live server? Was looking for ability to QA solutions in Storybook. |
Discussion: https://cxlworld.slack.com/archives/C01HNLQNVA9/p1683877197950619
Before:
After: