Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cxl-ui): [cxl-marketing-nav] allow menu to use full height after reposition #279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented May 12, 2023

@anoblet anoblet requested a review from a team May 12, 2023 11:46
@github-actions
Copy link

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 33.58 KB (+0.03% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 24.9 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 125.6 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 197.11 KB (+0.01% 🔺)

@lkraav
Copy link

lkraav commented May 12, 2023

Thanks. It's difficult to tell for QA where to look for before / after states. Can you edit PR opener with screenshots?

@anoblet
Copy link
Collaborator Author

anoblet commented May 12, 2023

@lkraav I'm not sure why, though I'm not able to replicate in Storybook. In Storybook bottom is not being set on the overlay. When I set bottom after the fact in dev tools for Institute to var(--lumo-space-m) on the overlay, the proper height is achieved.

This isn't ideal, though I'm not sure how to replicate this in Storybook.

@lkraav
Copy link

lkraav commented May 12, 2023

This isn't ideal, though I'm not sure how to replicate this in Storybook.

Maybe it's some race condition, and not a safe solution?

Still, intended result before / after screenshots are needed for reviewers to evaluate anything, even if "after" is with manual inspector modding right now.

@anoblet
Copy link
Collaborator Author

anoblet commented May 12, 2023

I added screenshots earlier, though didn't click update comment :/

They should be there now.

@lkraav
Copy link

lkraav commented May 12, 2023

I added screenshots earlier, though didn't click update comment :/ They should be there now.

Hmm, but this is on live server? Was looking for ability to QA solutions in Storybook.

@anoblet
Copy link
Collaborator Author

anoblet commented May 12, 2023

I'm not able to replicate in Storybook :/

localhost_6006__path=_story_cxl-ui-cxl-marketing-nav--cxl-marketing-nav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants