Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Improvements to the tabs #1673

Merged
merged 3 commits into from
Dec 25, 2024
Merged

Some Improvements to the tabs #1673

merged 3 commits into from
Dec 25, 2024
+61 −21

Conversation

Yaraslaut
Copy link
Member

Refs #1632
PR:

  • Fixes bug with crash on resize and tab switching, way to reproduce:
    • resize the window
    • create new tab
    • exit
    • create new tab (size will be wrong)
    • try to return the the previous tab (crash happening)
  • Implements wrapping of tab index when switching to left/right
  • Implements preservation of tab cwd on new tab spawn

@github-actions github-actions bot added the frontend Contour Terminal Emulator (GUI frontend) label Dec 18, 2024
@Yaraslaut Yaraslaut force-pushed the improvements/tabs branch 3 times, most recently from 868b154 to 7511d3f Compare December 20, 2024 09:46
@github-actions github-actions bot added test Unit tests VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library labels Dec 20, 2024
christianparpart
christianparpart requested changes Dec 20, 2024
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for taking it. But can we probably apply the two very minors mentioned?

metainfo.xml Outdated Show resolved Hide resolved
src/contour/TerminalSessionManager.cpp Outdated Show resolved Hide resolved
@Yaraslaut Yaraslaut force-pushed the improvements/tabs branch 4 times, most recently from 701d3c0 to f46e442 Compare December 25, 2024 10:05
christianparpart
christianparpart previously approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@christianparpart christianparpart added the no changelog Tells the CI to not require a changelog entry label Dec 25, 2024
@christianparpart christianparpart merged commit 96a01b6 into master Dec 25, 2024
30 of 31 checks passed
@christianparpart christianparpart deleted the improvements/tabs branch December 25, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianparpart christianparpart christianparpart left review comments

Assignees
No one assigned
Labels
frontend Contour Terminal Emulator (GUI frontend) no changelog Tells the CI to not require a changelog entry test Unit tests VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yaraslaut @christianparpart