Fix unchecked build warnings #1469
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfi
force-pushed
the
fix-build-warnings
branch
from
7bd8774 to
9829132
Compare
nfi
force-pushed
the
fix-build-warnings
branch
from
9829132 to
619eba0
Compare
pjonsson
reviewed
Dec 1, 2024
| @@ -173,7 +173,7 @@ public void endDraggingFrame(JComponent f) { | |||
| } | |||
| }); | |||
| // Dragging windows on OS X leaves residue from the borders with FlatLaf, so avoid setting dragMode. | |||
| if (cooja.configuration.lookAndFeel() != LookAndFeel.FlatLaf) { | |||
| if (Cooja.configuration.lookAndFeel() != LookAndFeel.FlatLaf) { | |||
There was a problem hiding this comment.
I was aware of a few of these warnings but left them because I was hoping the static member would eventually become non-static. But that's not happening anytime soon, so might as well do this.
|
I tried to untangle these parts before but wasn't successful. I have skimmed the PR and it looks fine, but I think we should wait with merging this until after the release is completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.