ContikiMoteType: speed up variable parsing on Linux #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the interface and just parse the two variants differently.
The Scanner is slow and allocates a lot of memory, so only scan the lines that we are interested in.
nfi
reviewed
Oct 4, 2023
nfi
approved these changes
Oct 4, 2023
|
@kkrentz what version of readelf is used? Can you paste the output from |
|
|
Does it work if you change line 286 in ContikiMoteType.java from |
|
Yes, the error disappears. Thanks. |
pjonsson
added a commit
to pjonsson/cooja
that referenced
this pull request
Oct 6, 2023
Issue identified by kkrentz in contiki-ng#1343.
kkrentz
pushed a commit
to kkrentz/cooja
that referenced
this pull request
Oct 20, 2023
Issue identified by kkrentz in contiki-ng#1343.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.