Merge pull request #1360 from pjonsson/contikieeprom-fixes

ContikiEEProm: fix various IntelliJ warnings
contiki-ng · Oct 29, 2023 · a133cd8 · a133cd8
2 parents 0022abe + f42142c
commit a133cd8
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/java/org/contikios/cooja/contikimote/interfaces/ContikiEEPROM.java b/java/org/contikios/cooja/contikimote/interfaces/ContikiEEPROM.java
@@ -161,15 +161,15 @@ public int getLastWrittenCount() {
     return lastWritten;
   }
 
-  static String byteArrayToPrintableCharacters(byte[] data, int offset, int length) {
+  private static String byteArrayToPrintableCharacters(byte[] data, int offset, int length) {
       StringBuilder sb = new StringBuilder();
       for (int i = offset; i < offset + length; i++) {
-        sb.append(data[i] > 31 && data[i] < 128 ? (char) data[i] : '.');
+        sb.append(data[i] > 31 ? (char) data[i] : '.');
       }
       return sb.toString();
   }
 
-  static String byteArrayToHexList(byte[] data, int offset, int length) {
+  private static String byteArrayToHexList(byte[] data, int offset, int length) {
       StringBuilder sb = new StringBuilder();
 
       for (int i = 0; i < length; i++) {
@@ -186,7 +186,7 @@ static String byteArrayToHexList(byte[] data, int offset, int length) {
       return sb.toString();
   }
 
-  void redrawDataView(JTextArea textArea) {
+  private void redrawDataView(JTextArea textArea) {
       StringBuilder sb = new StringBuilder();
       Formatter fmt = new Formatter(sb);
       byte[] data = getEEPROMData();