Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VE-4530): exclude properties doesn't check for frame status on outsideLivePreviewPortal #310

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix(VE-4530): exclude properties doesn't check for frame status on outsideLivePreviewPortal #310

merged 2 commits into from
Dec 16, 2024
+138 −124

Conversation

hiteshshetty-dev
Copy link
Contributor

No description provided.

@hiteshshetty-dev hiteshshetty-dev requested a review from a team as a code owner December 16, 2024 07:19
@hiteshshetty-dev hiteshshetty-dev requested review from Deepak-Kharah, faraazb, sairajchouhan and srinad007 and removed request for a team December 16, 2024 07:19
srinad007
srinad007 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@srinad007 srinad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 47.91% 6108 / 12747
🔵 Statements 47.91% 6108 / 12747
🔵 Functions 71.62% 212 / 296
🔵 Branches 81.72% 644 / 788
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/livePreview/editButton/editButton.ts 96.97% 86.73% 94.44% 96.97% 107-109, 221-222, 266-267, 386, 408, 536-539
Generated in workflow #159 for commit d5f313c by the Vitest Coverage Report Action

@hiteshshetty-dev hiteshshetty-dev merged commit fa178d6 into develop_v3 Dec 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinad007 srinad007 srinad007 approved these changes

@Deepak-Kharah Deepak-Kharah Awaiting requested review from Deepak-Kharah

@faraazb faraazb Awaiting requested review from faraazb

@sairajchouhan sairajchouhan Awaiting requested review from sairajchouhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiteshshetty-dev @srinad007