Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VE-4326: increase timeout for new instance to render #308

Merged
merged 1 commit into from
Dec 6, 2024
Merged

VE-4326: increase timeout for new instance to render #308

merged 1 commit into from
Dec 6, 2024

Conversation

sairajchouhan
Copy link
Contributor

@sairajchouhan sairajchouhan requested a review from a team as a code owner December 6, 2024 11:16
@sairajchouhan sairajchouhan requested review from faraazb and removed request for a team December 6, 2024 11:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 47.89% 6105 / 12746
🔵 Statements 47.89% 6105 / 12746
🔵 Functions 71.62% 212 / 296
🔵 Branches 81.37% 638 / 784
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/utils/multipleElementAddButton.ts 88.77% 88.37% 100% 88.77% 84-85, 93, 96, 211-212, 250-276
Generated in workflow #156 for commit 862b350 by the Vitest Coverage Report Action

faraazb
faraazb approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@faraazb faraazb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sairajchouhan sairajchouhan merged commit 1b5cde7 into VC-115/live-editor-support Dec 6, 2024
5 of 6 checks passed
@sairajchouhan sairajchouhan deleted the VE-4326 branch December 6, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faraazb faraazb faraazb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sairajchouhan @faraazb