Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v3.0.1 #296

Merged
merged 12 commits into from
Nov 15, 2024
Merged

feat: v3.0.1 #296

merged 12 commits into from
Nov 15, 2024

Conversation

faraazb
Copy link
Contributor

@faraazb faraazb commented Nov 11, 2024 •
edited by srinad007
Loading

@faraazb faraazb requested a review from a team as a code owner November 11, 2024 14:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 48.08% 6123 / 12735
🔵 Statements 48.08% 6123 / 12735
🔵 Functions 71.42% 210 / 294
🔵 Branches 81.49% 634 / 778
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/livePreview/editButton/editButton.style.ts 100% 100% 100% 100%
src/visualBuilder/index.ts 64.05% 84.61% 42.85% 64.05% 74-81, 84-85, 88-97, 100-173, 179-212
src/visualBuilder/components/FieldToolbar.tsx 78.01% 62.85% 35.71% 78.01% 52-104, 142-143, 168-169, 196-199, 221-230, 252-253, 260-261, 264-265, 315-317, 341-347, 377, 409
src/visualBuilder/components/pseudoEditableField.tsx 100% 100% 100% 100%
src/visualBuilder/eventManager/useVariantsPostMessageEvent.ts 27.65% 100% 16.66% 27.65% 36-92, 98-99, 104-105, 110-111, 116-121, 126-127
src/visualBuilder/generators/generateToolbar.tsx 88.34% 62.5% 80% 88.34% 63, 77-80, 97-101, 130-131
src/visualBuilder/listeners/mouseClick.ts 87.31% 84% 75% 87.31% 85, 117-118, 147-153, 169-175
src/visualBuilder/utils/getPsuedoEditableStylesElement.ts 100% 100% 100% 100%
src/visualBuilder/utils/getStyleOfAnElement.ts 100% 100% 100% 100%
src/visualBuilder/utils/handleIndividualFields.ts 80.44% 71.42% 75% 80.44% 83, 138-139, 154, 184-186, 192-211, 271-279, 288-295
src/visualBuilder/utils/updateFocussedState.ts 2.91% 100% 0% 2.91% 27-74, 84-211, 218-441
Generated in workflow #149 for commit 372b865 by the Vitest Coverage Report Action

hiteshshetty-dev
hiteshshetty-dev previously approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@srinad007 srinad007 force-pushed the VC-115/live-editor-support branch from 4d026d1 to 372b865 Compare November 15, 2024 08:23
hiteshshetty-dev
hiteshshetty-dev approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@srinad007 srinad007 merged commit a4bb83e into main Nov 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiteshshetty-dev hiteshshetty-dev hiteshshetty-dev approved these changes

@aravindbuilt aravindbuilt aravindbuilt approved these changes

@Deepak-Kharah Deepak-Kharah Awaiting requested review from Deepak-Kharah

@srinad007 srinad007 Awaiting requested review from srinad007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@faraazb @aravindbuilt @hiteshshetty-dev @srinad007 @sairajchouhan