Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: hide overlay on delete event #295

Merged
merged 1 commit into from
Nov 11, 2024
Merged

chore: hide overlay on delete event #295

merged 1 commit into from
Nov 11, 2024

Conversation

sairajchouhan
Copy link
Contributor

No description provided.

@sairajchouhan sairajchouhan requested a review from a team as a code owner November 11, 2024 11:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 48.32% 6111 / 12645
🔵 Statements 48.32% 6111 / 12645
🔵 Functions 71.33% 209 / 293
🔵 Branches 81.46% 633 / 777
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/components/FieldToolbar.tsx 78.01% 62.85% 35.71% 78.01% 52-104, 142-143, 168-169, 196-199, 221-230, 252-253, 260-261, 264-265, 315-317, 341-347, 377, 409
src/visualBuilder/generators/generateToolbar.tsx 88.34% 62.5% 80% 88.34% 63, 77-80, 97-101, 130-131
src/visualBuilder/listeners/mouseClick.ts 87.31% 84% 75% 87.31% 85, 117-118, 147-153, 169-175
Generated in workflow #137 for commit 7a9a14e by the Vitest Coverage Report Action

faraazb
faraazb approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@faraazb faraazb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sairajchouhan sairajchouhan merged commit ebc671b into VC-115/live-editor-support Nov 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faraazb faraazb faraazb approved these changes

@hiteshshetty-dev hiteshshetty-dev Awaiting requested review from hiteshshetty-dev

@srinad007 srinad007 Awaiting requested review from srinad007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sairajchouhan @faraazb