Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: psuedo editable re-positioning logic #294

Conversation

faraazb
Copy link
Contributor

@faraazb faraazb commented Nov 11, 2024

We had duplicated re-positioning logic for mutation observer handling but it was not updated when the logic which runs when psuedo editable is created was updated.

I have now extracted a function which gets called in all the 3 instances.

@faraazb faraazb requested a review from a team as a code owner November 11, 2024 10:34
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 48.29% 6115 / 12662
🔵 Statements 48.29% 6115 / 12662
🔵 Functions 71.67% 210 / 293
🔵 Branches 81.46% 633 / 777
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/index.ts 64.51% 84.61% 42.85% 64.51% 74-80, 83-84, 87-96, 99-172, 178-210
src/visualBuilder/components/pseudoEditableField.tsx 100% 100% 100% 100%
src/visualBuilder/utils/getPsuedoEditableStylesElement.ts 100% 100% 100% 100%
src/visualBuilder/utils/getStyleOfAnElement.ts 100% 100% 100% 100%
src/visualBuilder/utils/handleIndividualFields.ts 80.8% 71.42% 75% 80.8% 83, 138-139, 154, 184-186, 192-210, 270-278, 287-294
src/visualBuilder/utils/updateFocussedState.ts 3.31% 100% 0% 3.31% 24-71, 81-184, 191-393
Generated in workflow #136 for commit c6c354b by the Vitest Coverage Report Action

Copy link
Contributor

@srinad007 srinad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@faraazb faraazb merged commit 1eb5894 into VC-115/live-editor-support Nov 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants