-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for nested global fields #230
Draft
sunil-lakshman
wants to merge
5
commits into
feature_nested_global_field
Choose a base branch
from
feature_nested_global_fields
base: feature_nested_global_field
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+677
−120
Draft
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
15dbab3
Added support for nested global fields
sunil-lakshman cfcad6d
Added updated method
sunil-lakshman 7e97085
Added update method testcases
sunil-lakshman a47ff36
Added mock file
sunil-lakshman ff4a22d
Fixed PR comments
sunil-lakshman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -159,12 +159,30 @@ export function Stack (http, data) { | |
* | ||
* client.stack({ api_key: 'api_key'}).globalField('globalField_uid').fetch() | ||
* .then((globalField) => console.log(globalField)) | ||
* | ||
* client.stack({ api_key: 'api_key'}).globalField('globalField_uid', { api_version: '3.2' }).fetch() | ||
* .then((globalField) => console.log(globalField)) | ||
* | ||
* client.stack({ api_key: 'api_key'}).globalField({ api_version: '3.2' }).fetch() | ||
* .then((globalField) => console.log(globalField)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @sunil-lakshman , We cannot call the fetch method without the uid. Right? I think the second example can be removed. |
||
*/ | ||
this.globalField = (globalFieldUid = null) => { | ||
const data = { stackHeaders: this.stackHeaders } | ||
if (globalFieldUid) { | ||
data.global_field = { uid: globalFieldUid } | ||
this.globalField = (globalFieldUidOrOptions = null, options = {}) => { | ||
let data = { | ||
stackHeaders: this.stackHeaders, | ||
}; | ||
if (typeof globalFieldUidOrOptions === 'object' && globalFieldUidOrOptions !== null) { | ||
options = globalFieldUidOrOptions; | ||
} else if (globalFieldUidOrOptions) { | ||
data.global_field = { uid: globalFieldUidOrOptions }; | ||
} | ||
|
||
if (options?.api_version) { | ||
data.api_version = options.api_version; | ||
if (options.api_version === '3.2') { | ||
data.nested_global_fields = true; | ||
} | ||
} | ||
|
||
return new GlobalField(http, data) | ||
} | ||
|
||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sunil-lakshman , pls correct the version here