Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [] add taxonomy entities in CMA client #2078

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: [] add taxonomy entities in CMA client #2078

wants to merge 1 commit into from

Conversation

maxcheremisin
Copy link
Member

@maxcheremisin maxcheremisin commented Nov 25, 2024 •
edited
Loading

Purpose of PR

Adds taxonomy entities types in CMAClient interface so it properly reflects CMA methods that should be accessible in BaseAppSDK['cma'].

PR Checklist

  • Tests are added/updated/not required
  • Tests are passing
  • Typescript typings are added/updated/not required

@maxcheremisin maxcheremisin requested a review from a team as a code owner November 25, 2024 15:48
mgoudy91
mgoudy91 previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@mgoudy91 mgoudy91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

Quick nit if you don't mind: looks like the cma client types are alphabetized, might as well maintain that convention

@maxcheremisin maxcheremisin force-pushed the feat/add_taxonomy_cma_types branch from ff33f97 to 1ac427a Compare November 25, 2024 17:18
@maxcheremisin maxcheremisin marked this pull request as draft November 26, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoudy91 mgoudy91 mgoudy91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxcheremisin @mgoudy91