-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:[]add catalog-info file #240
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Rémy Lenoir <[email protected]>
Signed-off-by: Rémy Lenoir <[email protected]>
Signed-off-by: Rémy Lenoir <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.. but bear in mind that this is a public repo and our customers fork this repo too as part of onboarding... @roryscarson - this file alone won't make any sense to them and could be confusing, but no harm either.
It won't show up in backstage since the fork will be in a different org so shouldn't impact our stuff, but I'll chat with the roadie team to see if they have something coming to handle this in a better way. Maybe just a comment in the file saying it's for our own internal checks, or having a .contentful folder where we dump things like this and SAST scanning that won't be used by forked repos. |
This pull request adds a catalog-info file to the repository.
You will need to modify the values inside before merging it.