Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[]add catalog-info file #240

Merged
merged 4 commits into from
Nov 6, 2023
Merged

fix:[]add catalog-info file #240

merged 4 commits into from
Nov 6, 2023

Conversation

cf-allstar[bot]
Copy link
Contributor

@cf-allstar cf-allstar bot commented Oct 26, 2023

This pull request adds a catalog-info file to the repository.

You will need to modify the values inside before merging it.

@cf-allstar cf-allstar bot requested a review from a team as a code owner October 26, 2023 14:07
@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
template-marketing-webapp-nextjs ✅ Ready (Inspect) Visit Preview Nov 2, 2023 4:12pm

catalog-info.yaml Outdated Show resolved Hide resolved
catalog-info.yaml Outdated Show resolved Hide resolved
catalog-info.yaml Outdated Show resolved Hide resolved
catalog-info.yaml Outdated Show resolved Hide resolved
catalog-info.yaml Outdated Show resolved Hide resolved
catalog-info.yaml Outdated Show resolved Hide resolved
catalog-info.yaml Outdated Show resolved Hide resolved
catalog-info.yaml Outdated Show resolved Hide resolved
Signed-off-by: Rémy Lenoir <[email protected]>
catalog-info.yaml Outdated Show resolved Hide resolved
Signed-off-by: Rémy Lenoir <[email protected]>
Copy link
Contributor

@AdrianLThomas AdrianLThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. but bear in mind that this is a public repo and our customers fork this repo too as part of onboarding... @roryscarson - this file alone won't make any sense to them and could be confusing, but no harm either.

@roryscarson
Copy link

It won't show up in backstage since the fork will be in a different org so shouldn't impact our stuff, but I'll chat with the roadie team to see if they have something coming to handle this in a better way. Maybe just a comment in the file saying it's for our own internal checks, or having a .contentful folder where we dump things like this and SAST scanning that won't be used by forked repos.

@cf-remylenoir cf-remylenoir merged commit 4695a37 into main Nov 6, 2023
4 checks passed
@cf-remylenoir cf-remylenoir deleted the add-catalog-info branch November 6, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants