feat: First commit, adding Lilt app to Contentful Marketplace #600
Conversation
the-julianson
force-pushed
the
feature/add-lilt
branch
from
b3fe6cd to
da6f8e3
Compare
There was a problem hiding this comment.
Hi! The app looks great, I confirmed that the various scripts work as intended.
Given that your app is an existing app in the marketplace and we need to transfer ownership of the app definition, could you please remove the two deploy scripts for now? I will then merge in this PR, and then after we transfer the production app definition to Contentful, I will open a PR to add those scripts back in. I will also configure this app to update a CHANGELOG in a follow up PR. Let me know if you have any questions!
There was a problem hiding this comment.
@the-julianson I just noticed some environment variables in the code that are not configured, so we will need to find a way to address this to ensure that the app functions properly.
| import { CloseTrimmedIcon } from '@contentful/f36-icons'; | ||
| import CMClient from './contentful-management-client'; | ||
|
|
||
| const BASE_URL = process.env.CONNECTORS_BASE_URL; |
There was a problem hiding this comment.
These environment variables (CONNECTORS_BASE_URL, HYDRA_CLIENT_ID, and HYDRA_CLIENT_STATE) were likely configured in your repo where this app was hosted previously, but are not configured here.
There was a problem hiding this comment.
@whitelisab Yes, let me get back to you with those values. We were using Kubernetes to handle the env vars.
Where are you storing the values for env vars? Is it ok If I pass those to you?
|
@whitelisab I have a couple of questions: Another question, how to handle the different environments. We were using branch tagging to trigger automatic deployment to our DEV (LILT Preview) and our PROD (LILT) instances. |
Purpose
First commit to move our Lilt extension to the Contentful Marketplace.
Approach
Follow the steps in the main README.md of the current repository.