chore: app review workflow works for forked branches[INTEG-2165] #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahlessner
commented
Jan 23, 2025
| @@ -11,7 +11,7 @@ | |||
| "@actions/github": "^6.0.0", | |||
| "@types/node": "^22.3.0", | |||
| "husky": "^8.0.0", | |||
| "lint-staged": "^13.2.1", | |||
| "lint-staged": "^15.4.2", | |||
There was a problem hiding this comment.
Just a dependency update that came up running npm audit that didn't have any breaking changes to worry about with the fix.
sarahlessner
commented
Jan 23, 2025
| with: | ||
| # Fetch all history for all branches and tags |
There was a problem hiding this comment.
This is a solution I found to the issue, but I can't really think of a way to test this out without having this workflows file merged in first. If I made this change on a forked repo branch I don't feel confident that it would work reliably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Approach
Testing steps
Breaking Changes
Dependencies and/or References
Deployment