Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forgotten things from the vitest migration #2485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Forgotten things from the vitest migration #2485

wants to merge 1 commit into from

Conversation

axe312ger
Copy link
Collaborator

@axe312ger axe312ger commented Nov 26, 2024 •
edited
Loading

  • removes obsolete express dependency
  • rewrites two tests who stayed in old syntax as I overlooked them in a merge
  • delete obsolete file (generate-random-ids.ts)
  • exports uploadCredential mock

@axe312ger axe312ger requested a review from a team as a code owner November 26, 2024 11:08
@axe312ger axe312ger mentioned this pull request Nov 26, 2024
Closed
@mgoudy91 mgoudy91 force-pushed the fix/forgotten-things branch from 4e7fb82 to 05fb856 Compare December 3, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoudy91 mgoudy91 mgoudy91 approved these changes

Assignees
No one assigned
Labels
awaiting feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axe312ger @mgoudy91