fix: https-proxy-agent usage after version bump [NONE] (#206)

* fix: https-proxy-agent usage after version bump [NONE]

* chore: pin version of ESM only modules [NONE]

.github/dependabot.yml

@@ -8,6 +8,13 @@ updates:
       time: "00:00"
       timezone: UTC
     open-pull-requests-limit: 10
+    ignore:
+      - dependency-name: bfj # ignore ESM only versions
+        versions:
+          - ">=8.0.0"
+      - dependency-name: figures  # ignore ESM only versions
+        versions:
+          - ">=4.0.0"
     commit-message:
       prefix: build
       include: scope

lib/proxy.js

@@ -1,5 +1,5 @@
-import { URL, format } from 'url'
-import HttpsProxyAgent from 'https-proxy-agent'
+import { format, URL } from 'url'
+import { HttpsProxyAgent } from 'https-proxy-agent'
 
 function serializeAuth ({ username, password } = {}) {
   if (!username) {
@@ -62,7 +62,6 @@ export function agentFromProxy (proxy) {
     delete process.env[envStr]
     delete process.env[envStr.toUpperCase()]
   })
-  const { host, port, protocol } = proxy
-  const agent = new HttpsProxyAgent({ host, port, protocol })
-  return agent
+
+  return new HttpsProxyAgent(proxyObjectToString(proxy))
 }

package.json

@@ -23,9 +23,9 @@
     "prepush": "npm run test"
   },
   "dependencies": {
-    "bfj": "^8.0.0",
+    "bfj": "7.1.0",
     "date-fns": "^2.28.0",
-    "figures": "^5.0.0",
+    "figures": "3.2.0",
     "https-proxy-agent": "^7.0.2",
     "lodash.clonedeep": "^4.5.0",
     "uuid": "^9.0.1"

test/proxy.test.js

@@ -1,9 +1,10 @@
-import HttpsProxyAgent from 'https-proxy-agent'
+import { HttpsProxyAgent } from 'https-proxy-agent'
 import {
   proxyStringToObject,
   proxyObjectToString,
   agentFromProxy
 } from '../lib/proxy'
+import expect from 'expect'
 
 jest.mock('https-proxy-agent')
 
@@ -127,7 +128,7 @@ test('agentFromProxy creates https agent and removes proxy env variables', () =>
   const agent = agentFromProxy(agentParams)
 
   expect(agent).toBeInstanceOf(HttpsProxyAgent)
-  expect(HttpsProxyAgent.mock.calls[0][0]).toMatchObject(agentParams)
+  expect(HttpsProxyAgent.mock.calls[0][0]).toBe(proxyObjectToString(agentParams))
 
   expect(process.env).not.toHaveProperty('HTTP_PROXY')
   expect(process.env).not.toHaveProperty('http_proxy')