Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused CONTENTFUL_HOST environment variable #9344

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove unused CONTENTFUL_HOST environment variable #9344

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f6044e
Remove unused CONTENTFUL_HOST environment variable
twogood Dec 17, 2024
c0c0204
Merge branch 'master' into native-external-references-clean-up-for-wi…
Seth-Carter Dec 18, 2024
a069b3c
Use cross-env based on PR feedback
twogood Dec 18, 2024
110dce1
Merge branch 'master' of https://github.com/contentful/apps into nati…
twogood Dec 18, 2024
fa39ce8
Merge branch 'native-external-references-clean-up-for-windows-users' …
twogood Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/native-external-references/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
"prettier": "prettier --write functions",
"open-settings": "contentful-app-scripts open-settings",
"install-app": "contentful-app-scripts install",
"create-resource-entities": "CONTENTFUL_HOST=api.contentful.com ts-node -T -r dotenv/config ./src/tools/create-resource-entities.ts",
"show-resource-entities": "CONTENTFUL_HOST=api.contentful.com ts-node -T -r dotenv/config ./src/tools/show-resource-entities.ts"
"create-resource-entities": "ts-node -T -r dotenv/config ./src/tools/create-resource-entities.ts",
twogood marked this conversation as resolved.
Show resolved Hide resolved
"show-resource-entities": "ts-node -T -r dotenv/config ./src/tools/show-resource-entities.ts"
twogood marked this conversation as resolved.
Show resolved Hide resolved
},
"eslintConfig": {
"extends": "react-app"
Expand Down
2 changes: 0 additions & 2 deletions examples/native-external-references/src/tools/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ import {
type ResourceProviderResult = APIError | APIResourceProvider;
type ResourceTypeResult = APIError | APIResourceType;

twogood marked this conversation as resolved.
Show resolved Hide resolved
const host = process.env.CONTENTFUL_HOST ?? 'api.contentful.com';

const client = createClient({ accessToken }, { type: 'plain' });

const put = async <T>({ resource, url }: { resource: string; url: string }) => {
Expand Down