Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump go/stdlib to v1.23.x and update go modules #2047

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nemezo
Copy link

@nemezo nemezo commented Oct 31, 2024

What this PR Contributes

This pull request upgrades the Go environment to version 1.23 and updates the module dependencies to their latest versions in go.mod. Additionally, it refactors code to align with recent API changes in Docker and other related modules, improving maintainability and compatibility with current libraries.

Changes Summary

  • Go Version Upgrade: Upgraded go.mod to Go 1.23.
  • Module Updates: Updated all dependencies to their latest stable versions.
  • Refactoring for Compatibility:
    • Updated ContainerListOptions to container.ListOptions and refactored related Docker structs.
    • Replaced types.ImageDeleteResponseItem with image.DeleteResponse for compatibility.
    • Modified ImagePullOptions and ContainerRemoveOptions to reflect updated package paths.

Issues Solved

  • This PR enhances compatibility and security by updating outdated dependencies, addressing CVEs identified in the SBOM, and aligning with current API specifications.

Tests and Verification

All existing unit tests have been executed to verify that the updates and refactoring do not introduce regressions. No tests failed, confirming that the modifications are stable and align with the expected functionality.

Unit-Test output:

SUCCESS! -- 21 Passed | 0 Failed | 0 Pending | 0 Skipped
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 0 Skipped
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
SUCCESS! -- 66 Passed | 0 Failed | 0 Pending | 0 Skipped
SUCCESS! -- 41 Passed | 0 Failed | 0 Pending | 0 Skipped
SUCCESS! -- 7 Passed | 0 Failed | 0 Pending | 0 Skipped
SUCCESS! -- 11 Passed | 0 Failed | 0 Pending | 1 Skipped
SUCCESS! -- 4 Passed | 0 Failed | 0 Pending | 3 Skipped
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 0 Skipped
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 0 Skipped

Documentation Updates

No major documentation updates are required, as the changes pertain primarily to internal struct names and module paths.

- Upgraded `go.mod` to use Go 1.23 and updated module dependencies to latest versions
- Refactored code to align with API changes in Docker and related modules:
  - Updated `ContainerListOptions` to `container.ListOptions` and related structs
  - Replaced `types.ImageDeleteResponseItem` with `image.DeleteResponse` for compatibility
  - Modified `ImagePullOptions` and `ContainerRemoveOptions` to updated package paths
@nemezo nemezo requested a review from simskij as a code owner October 31, 2024 13:40
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on opening your first pull request! We'll get back to you as soon as possible. In the meantime, please make sure you've updated the documentation to reflect your changes and have added test automation as needed. Thanks! 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant