fix(smtp): use param props from params arg #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
==========================================
- Coverage 79.12% 79.11% -0.01%
==========================================
Files 102 102
Lines 4488 4486 -2
==========================================
- Hits 3551 3549 -2
Misses 758 758
Partials 179 179 ☔ View full report in Codecov by Sentry. |
was ignoring encryption, subject, fromname and fromaddress
JosephKav
commented
Jan 19, 2024
| @@ -71,7 +71,7 @@ func (service *Service) Send(message string, params *types.Params) error { | |||
| return fail(FailApplySendParams, err) | |||
| } | |||
|
|
|||
| client, err := getClientConnection(service.config) | |||
| client, err := getClientConnection(&config) | |||
There was a problem hiding this comment.
if useImplicitTLS(config.Encryption, config.Port) {
conn, err = tls.Dial("tcp", addr, &tls.Config{
ServerName: config.Host,
})
} else {
conn, err = net.Dial("tcp", addr)
}This was ignoring the value in the params var
JosephKav
commented
Jan 19, 2024
| @@ -239,7 +237,7 @@ func (service *Service) getHeaders(toAddress string, subject string) map[string] | |||
| } | |||
|
|
|||
| return map[string]string{ | |||
| "Subject": subject, | |||
| "Subject": conf.Subject, | |||
There was a problem hiding this comment.
conf.Subject may contain changes from the var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was ignoring encryption, subject, fromname and fromaddress
Noticed from release-argus/Argus#352 - Setting fromname in param props that are given with
sender.Send(toSend, params)was ignored.