-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#404): implement basic webex functionality to shoutrrr #405
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really well done. Good job!
My suggestion would be to pass the roomId as a query parameter instead to allow for sending to multiple rooms. It would require the hostname to be a static string (which is generally just ignored by other services that have this problem).
Also, even though it's very simple, add the macro for including auto-generated docs so that the docs align with the other services. It's the scissor-looking thing at the bottom of the other services markdown files.
Thanks very much! Query param for roomID, fair enough I will take a poke. Do you have an example other service? Ooh I see, I wondered what that was for. Thanks for the clarification, I will add the scissors when I have a moment. :) |
Sure, the telegram service is similar and loops over its targets (
It's configured using the
Even if you only support a single room for now, using a query variable allows for adding support for multiple ones in the future without breaking compatibility. It also aligns it better with the other services. Thanks for taking the time! |
|
Just a whee nudge 😄 Also quick Q: How long would it be before we can expect watchtower and shepard to update with the new version? |
Implements a basic version of webex, future plans to add cards as well, but for now this satisfies webex being available.
closes #404 (heh, 404)