Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve notifications handling #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve notifications handling #129

wants to merge 2 commits into from

Conversation

Steeven9
Copy link

@Steeven9 Steeven9 commented Apr 7, 2024 •
edited
Loading

Improved a bit the Apprise notification handling:

  • made curl silent so we don't see the ugly progess bar in the logs anymore
  • adapted the notification type parameter (depends on this PR: Add notification type djmaze/apprise-microservice#8)
  • refactored code to extract the notification sending in a separate function to reduce code duplication
  • added a log entry to indicate whether the notification was successful or not with the curl result

djmaze
djmaze approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@djmaze djmaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

But waiting for the other PR to be merged.

@Steeven9
Copy link
Author

Can we merge it now that the other one is merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djmaze djmaze djmaze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Steeven9 @djmaze