Build Windows binary #2443
Open
Build Windows binary #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yasuhiro Matsumoto <[email protected]>
Signed-off-by: Yasuhiro Matsumoto <[email protected]>
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
A friendly reminder that this PR had no activity for 30 days. |
mtrmac
reviewed
Nov 15, 2024
|
|
||
| # N/B: This value is managed by Renovate, manual changes are | ||
| # possible, as long as they don't disturb the formatting | ||
| # (i.e. DO NOT ADD A 'v' prefix!) | ||
| GOLANGCI_LINT_VERSION := 1.61.0 | ||
|
|
||
| ifeq ($(GOBIN),) | ||
| GOBIN := $(GOPATH)/bin | ||
| GOBIN := $(subst \,/,$(shell $(GO) env GOPATH))/bin |
There was a problem hiding this comment.
This is surprising to me. make doesn’t like native-style paths? Which implementation is this?
There was a problem hiding this comment.
On Windows, GOPATH include backslash not slash.
Makefile
Outdated
| @@ -99,11 +99,16 @@ ifeq ($(DISABLE_CGO), 1) | |||
| override BUILDTAGS = exclude_graphdriver_btrfs containers_image_openpgp | |||
| endif | |||
|
|
|||
| BIN=bin/skopeo | |||
There was a problem hiding this comment.
Naming this something a bit more explicit would help. SKOPEO_BIN? SKOPEO_TARGET?
There are quite a few other instances of bin/skopeo in the Makefile, why don’t they need updating?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.