Fix TypeError in container's wait method #187
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mrbazzan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Abdulwasiu Apalowo <[email protected]>
Signed-off-by: Abdulwasiu Apalowo <[email protected]>
| @@ -77,7 +77,7 @@ def run( | |||
| if log_type in ("json-file", "journald"): | |||
| log_iter = container.logs(stdout=stdout, stderr=stderr, stream=True, follow=True) | |||
|
|
|||
| exit_status = container.wait()["StatusCode"] | |||
| exit_status = container.wait() | |||
| if exit_status != 0: | |||
There was a problem hiding this comment.
how does this check still work if you remove the ["StatusCode"] aspect? now you are checking if DICT != 0
There was a problem hiding this comment.
The return value from container.wait() is an integer not a dict, right?(unless I'm missing something...)
There was a problem hiding this comment.
def wait(self, **kwargs) -> Dict[Literal["StatusCode", "Error"], Any]:
Looks like to original code is correct
There was a problem hiding this comment.
Wait wait wait, there is definitely an issue here.
By default, wait() in podman-py uses the libpod operation ContainerwaitLibPod, which returns a JSON-encoded integer. For that case, the type annotation
def wait(self, **kwargs) -> Dict[Literal["StatusCode", "Error"], Any]:
isn't correct. That annotation matches the podman compat API, where ContainerWait returns a JSON object with the expected Keys Error and StatusCode.
I just discovered podman-py and don't know the code base enough yet to fix it myself, but would recommend to look into that issue again. I got here having experienced the same issue as in #201
|
@rhatdan wondering why this was closed, as the issue is still present. As @sylencecc points out, the proposed fix is correct, but the type annotation for the return type of |
|
I don't remember but might have been lack of activity. Care to open a new PR based on this? |
For the doc change: list of string does not work with
environmentargumentFixes No.3 in #184,
.wait()returns an integer not a dictionary