[skip-ci] TMT: revdep podman build test #1892
Conversation
|
Failed to load packit config file: For more info, please check out the documentation or contact the Packit team. You can also use our CLI command |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Failed to load packit config file: For more info, please check out the documentation or contact the Packit team. You can also use our CLI command |
|
Failed to load packit config file: For more info, please check out the documentation or contact the Packit team. You can also use our CLI command |
lsm5
changed the title
lsm5
force-pushed
the
tmt-podman-revdep
branch
5 times, most recently
from
a7c3e39
to
815cd3a
Compare
|
@Luap99 @edsantiago @TomSweeneyRedHat PTAL. Still in draft and not ready for merge either way, but if this looks ok for starters, I'd like further comments on the test matrix to enable. Right now it's only fedora-rawhide-x86_64. |
There was a problem hiding this comment.
I am not so sure how much value a build test adds, IMO build breaks are generally known by the submitter/reviewer. I guess it adds some value to prevent accidental breakages but I don't think they are very common.
I am not against doing something like this but I think we should have proper discussion first. And as a PoC could you add a "broken" commit here to see how this would look like when it fails?
plans/podman_build_test.sh
Outdated
| git clone https://github.com/containers/podman | ||
|
|
||
| cd podman | ||
| dnf -y builddep rpm/podman.spec |
There was a problem hiding this comment.
shouldn't this stuff be installed in the prepare step?
There was a problem hiding this comment.
That would be doable if we're only running podman tests. If we also want to do buildah, skopeo and anything else, then probably best done in individual tests.
plans/main.fmf
Outdated
| summary: Build Podman | ||
| execute: | ||
| how: tmt | ||
| script: bash ./plans/podman_build_test.sh |
There was a problem hiding this comment.
As it's not directly related to building, running, or documenting podman perhaps this could live under ./contrib/tmtplans or similar?
plans/podman_build_test.sh
Outdated
|
|
||
| if [ -f /etc/fedora-release ]; then | ||
| export TMPDIR=/var/tmp | ||
| fi |
There was a problem hiding this comment.
It's unclear to me (a lay person, non-tmt expert) why this is needed. Perhaps a comment would be helpful to other non-experts?
plans/podman_build_test.sh
Outdated
| git add vendor/ | ||
| git config --global user.email "[email protected]" | ||
| git config --global user.name "Your Name" | ||
| git commit -am 'add vendored files' |
There was a problem hiding this comment.
Consider grouping all the git repository setup steps together. It will make both the logs and the script easier to read and maintain.
|
It would be nice to get @edsantiago 's eyeballs on this if you have the time to wait. |
Co-authored-by: Chris Evich <[email protected]> Signed-off-by: Lokesh Mandvekar <[email protected]>
| @@ -0,0 +1,24 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| set -eox pipefail | |||
There was a problem hiding this comment.
| set -eox pipefail | |
| set -exo pipefail |
The order here is important.
| if [ -f /etc/fedora-release ]; then | ||
| export TMPDIR=/var/tmp | ||
| fi |
There was a problem hiding this comment.
Why the conditional? In all test environments I've seen, /var/tmp is much bigger than /tmp. It seems safest just to universally set TMPDIR=/var/tmp.
| export TMPDIR=/var/tmp | ||
| fi | ||
|
|
||
| git clone https://github.com/containers/podman |
There was a problem hiding this comment.
This script is named buildah_build_test but there's no buildah anything anywhere?
Now I understand the script names. Suggestion: rename both to "build_XXX" instead of XXX_build? "buildah_build_test," to me, suggests that you are testing buildah's build command.
No description provided.