-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a canary CI target to test against upcoming dependencies #3209
Conversation
2a8b826
to
71bf51b
Compare
91cc62d
to
deb1149
Compare
@AkihiroSuda
[update] reverting to draft for now. I like the idea of scraping versions to get the latest for everything instead of having to manually maintain these. This requires a little bit more work scraping github. |
44b0197
to
ae5164e
Compare
CI is still running, but nevertheless, this is ready for the most part. What this is now doing:
This is automatic - we do not have to manually maintain this file. I initially considered running (some) deps against their main / master, but after some tests, it seems like more trouble than reward. Pending CI being green (or further comments here), PTAL at your convenience. |
42cfd15
to
faca9aa
Compare
Signed-off-by: apostasie <[email protected]>
@AkihiroSuda I think we are getting close. Comment has been addressed, and now Windows also autodetect latest containerd. I am now using the GITHUB_TOKEN magically injected secret. PTAL at your convenience. Sorry for the churn here. This one obviously needed a little bit of back and forth - and your suggestion to automate retrieval of latest Go prompted an interesting direction for the rest. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This PR introduces a new CI target (held in a separate file) that uses unreleased, upcoming, or otherwise
main
versions of our dependencies.Specifically, it is setting us forward on:
and a few others on main.
The purpose of this is to constantly have a "canary" target that will let us proactively identify and address upcoming issues in our dependency ecosystem.
Right now, it is not testing everything. Specifically ignored on this target are freebsd and ipv6 targets.
This will fix #3208
This PR also modifies slightly our "main" testing targets to pin containerd to an actual RC instead of main.
This is now running "green" - but of course would love feedback here so if you folks feel anything is missing / should be done differently, lmk and happy to discuss.