Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the created tasks cannot be deleted #3203

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

Iceber
Copy link
Member

@Iceber Iceber commented Jul 8, 2024

task.Delete only allows direct deletion of tasks with PID 0.

fix: containerd/containerd#10438

Related pr: containerd/containerd#10442

@apostasie
Copy link
Contributor

apostasie commented Jul 8, 2024

Moving the conversation back in nerdctl then (since the original ticket had been moved to containerd).

Finally stumbled upon a repro:

{ sleep 1; echo "\16\17"; } | /usr/bin/unbuffer -p nerdctl run -it --name foobar ghcr.io/stargz-containers/alpine:3.13-org

nerdctl rm -f foobar
ERRO[0000] 1 errors:
task must be stopped before deletion: created: failed precondition

Also confirming that this PR does fix the issue.

@AkihiroSuda ^
I would love to get this in...

@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Jul 9, 2024
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit ddf5016 into containerd:main Jul 9, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unremovable container in created state (task must be stopped before deletion: created: failed precondition)
3 participants