CI test fix: wait for systemd to come up #3198
Conversation
|
Windows failure is unrelated and likely fixed by #3133 PTAL at your convenience. |
|
Latest push does increase the timeout to 10 seconds. |
Signed-off-by: apostasie <[email protected]>
|
@AkihiroSuda changing test condition did change the timing slightly, then changing systemd response ( Latest push adapts to that...... This test is not really good honestly... |
| exit 1 | ||
| } | ||
| done | ||
| systemctl list-jobs`).AssertOutContains("jobs") |
There was a problem hiding this comment.
Maybe use AssertOutWithFunc to check stdout == "No jobs running." || stdout == "jobs listed"
There was a problem hiding this comment.
I do not see the point in testing stdout at all here.
We should not be in the business of testing systemd, especially on matching random mundane non-error messages.
What matters here is that systemd is up and running (exit code 0), and that we have a test that does not fail randomly (that is the point of this PR).
I would rather leave this stuff as-is for now - until we come back here to write more useful versions of these tests.
What do you think?
Seen many times with canary #3189 - see #3186 for full list of pain.