Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRIORITY] Do not hard error if containers are gone #3192

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

apostasie
Copy link
Contributor

@apostasie apostasie commented Jul 5, 2024

This is another instance of #3167 (see ticket for rationale - in a shell: do not assume containers are still there after a call to client.Containers...)

In that specific case, it will make create fail if another unrelated container got removed in a racy way.

It is very likely responsible for a large number of failures on the CI, and definitely strikes more with parallelization.

This very likely will address #3092, #3186, and possibly a number of others.

@AkihiroSuda @fahedouch if you are around - would appreciate a quick merge on this, preferably before other QA/CI PRs so that I can rebase and see what problems are left (specifically for the IPFS one).

Of course, I will rebase #3189 as well ASAP which should give us a good hint.

Finally, if this is as bad as I think it is, merging this should give us a good speed boost on the CI (as a lot of "retries" will no longer be necessary).

Thanks a lot!

@apostasie apostasie changed the title Do not hard error if containers are gone [PRIORITY] Do not hard error if containers are gone Jul 5, 2024
@apostasie
Copy link
Contributor Author

Note: in the future, when we will be in a better position wrt CI, I will add tests to stress concurrency to ensure these problem patterns do not get reintroduced in the codebase.

@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Jul 5, 2024
@apostasie
Copy link
Contributor Author

Note: failure seems entirely unrelated (systemd socket something)

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@apostasie
Copy link
Contributor Author

Last run failure on integ-rootless is IPFS - these should get fixed soon with #3181

@AkihiroSuda AkihiroSuda merged commit 3caf416 into containerd:main Jul 6, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants