fix wrong terminal size on windows #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this commit broke getting the terminal size on windows: 342c47e They modified the size of the `wAttributes` field on `CONSOLE_SCREEN_BUFFER_INFO`. This appears to have been a mistake as it looks like they probably just did a search/replace of all the `u16` types with `u32`, however, we can't change the size of this field as it's defined by the OS and in doing so our `srWindow` offset is now incorrect.
|
Oops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this commit broke getting the terminal size on windows:
342c47e
They modified the size of the
wAttributesfield onCONSOLE_SCREEN_BUFFER_INFO. This appears to have been a mistake as it looks like they probably just did a search/replace of all theu16types withu32, however, we can't change the size of this field as it's defined by the OS and in doing so oursrWindowoffset is now incorrect.