Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create subpackage httphandlers, refactor getRootURL #42

Merged
merged 3 commits into from
Oct 30, 2017

Conversation

fawick
Copy link
Contributor

@fawick fawick commented Oct 29, 2017

To start factoring out the HTTP handlers I suggest a new package httphandlers. I decided to not name it http to distinguish it from net/http.

For the initial commit of this package I decided to move the functionality in func getRootURL out and remove the dependency on labstack/echo. The old function that uses echo is kept as a convenience function in main.go.

Update #40.

Copy link
Collaborator

@brendan-ward brendan-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fawick this looks great. Only comment is on package name. What about simply handlers, in the spirit of gorilla/handlers.

@fawick fawick force-pushed the refactorGetRootURL branch 2 times, most recently from fbe149e to 5ccb4db Compare October 29, 2017 19:34
@fawick
Copy link
Contributor Author

fawick commented Oct 29, 2017

Okay, renamed to handlers.

@fawick fawick force-pushed the refactorGetRootURL branch from 5ccb4db to 4a33d65 Compare October 29, 2017 19:44
@fawick fawick mentioned this pull request Oct 29, 2017
@fawick fawick force-pushed the refactorGetRootURL branch from 4a33d65 to d888e4b Compare October 29, 2017 20:24
@brendan-ward brendan-ward merged commit edeba9d into consbio:master Oct 30, 2017
@fawick fawick deleted the refactorGetRootURL branch October 30, 2017 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants