Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{% cache %} block wrapping Rails.cache.fetch (hosting) #1

Open
wants to merge 11 commits into
base: hosting
Choose a base branch
from

Conversation

conroywhitney
Copy link
Owner

Thank you for all of your work on LocomotiveCMS!

This is a companion pull request to locomotivecms#10 for the hosting branch.

did and others added 11 commits September 16, 2014 12:44
cache -- include activesupport gem; basic tag with spec

cache -- get key from options hash

cache -- swap order of options/tokens per send_mail example

cache -- accept array of key parts to join with separator

cache -- renamed to Cacher; creating composite key from given string

cache -- remove single quote from user submitted key

cache -- error => undefined method `context' for #<Liquid::Document

cache -- remove error_mode = :strict per tag/for example

cache -- remove whitespace around key

cache -- use Rails.cache in production

cache -- check for dalli gem to use Rails.cache

cache -- check for rails gem to use Rails.cache

cache -- remove both single and double quotes

cache -- inherit Solid::Block -- use variables in cache key

cache -- removed unused argument parsing method

cache -- don't add blank user parts

cache -- renamed variable cache_mechanism

cache -- remove wrapping slashes

cache -- change key root namespace prefix to 'locomotive'

cache -- remove logging unless in development

cache -- convert specs from .should to expect().to syntax

cache -- set Gemfile back to original so no spurious merge items
Conflicts:
	Gemfile.lock
cache -- include activesupport gem; basic tag with spec

cache -- get key from options hash

cache -- swap order of options/tokens per send_mail example

cache -- accept array of key parts to join with separator

cache -- renamed to Cacher; creating composite key from given string

cache -- remove single quote from user submitted key

cache -- error => undefined method `context' for #<Liquid::Document

cache-hosting -- remove dependency on locomotivecms-solid gem

cache-hosting -- trying to make same as original hosting branch

cache-hosting -- Gemfile.lock (trying to get like hosting branch)

cache -- remove error_mode = :strict per tag/for example

cache -- remove whitespace around key

cache -- use Rails.cache in production

cache -- check for dalli gem to use Rails.cache

cache -- check for rails gem to use Rails.cache

cache -- remove both single and double quotes

cache -- inherit Solid::Block -- use variables in cache key

cache -- removed unused argument parsing method

cache -- don't add blank user parts

cache -- renamed variable cache_mechanism

cache -- remove wrapping slashes

cache -- change key root namespace prefix to 'locomotive'

cache -- remove logging unless in development

cache -- convert specs from .should to expect().to syntax

cache -- set Gemfile back to original so no spurious merge items

cache-hosting -- remove spurious commit from .gemspec
@conroywhitney conroywhitney changed the title Cache hosting Cache Liquid block wrapping Rails.cache.fetch (hosting branch) Dec 17, 2014
@conroywhitney conroywhitney changed the title Cache Liquid block wrapping Rails.cache.fetch (hosting branch) {% cache %} block wrapping Rails.cache.fetch (hosting branch) Dec 17, 2014
@conroywhitney conroywhitney changed the title {% cache %} block wrapping Rails.cache.fetch (hosting branch) {% cache %} block using Rails.cache.fetch (hosting) Dec 17, 2014
@conroywhitney conroywhitney changed the title {% cache %} block using Rails.cache.fetch (hosting) {% cache %} block wrapping Rails.cache.fetch (hosting) Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants