Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apt repo check when using archive install #1846

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

henrygriffiths
Copy link

@henrygriffiths henrygriffiths commented Dec 2, 2024

Description

When running playbooks on Ubuntu based systems, the script still runs some apt checks when the archive installation method is configured. This adds additional checks to prevent running the apt commands when using an archive install.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Resolved issue with adding apt repo when using archive install on PS Engagement Client's CP install

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@henrygriffiths henrygriffiths requested a review from a team as a code owner December 2, 2024 21:34
@confluent-cla-assistant
Copy link

confluent-cla-assistant bot commented Dec 2, 2024

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ henrygriffiths
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant