-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude log by Event Id #53
Conversation
…ogs if the log event id is on the provided list. Prepare 9.3.0 release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of a list of event ids to exclude, I would strongly consider adding some filter callback to the options (could be a lambda or interface). I think it would be a more flexible API because then we could pass the whole context of the log event (log level, event id, message, exception) to this callback, which would allow consumers to implement more complex pieces of filtering logic as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, this comment looks like outdated.
Co-authored-by: adams85 <[email protected]>
Quality Gate passedIssues Measures |
Describe the purpose of your pull request
Requirement checklist (only if applicable)