Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude log by Event Id #53

Merged
merged 7 commits into from
Jul 4, 2024
Merged

Exclude log by Event Id #53

merged 7 commits into from
Jul 4, 2024

Conversation

novalisdenahi
Copy link
Contributor

Describe the purpose of your pull request

  • Added excludeLogEventIds options to the client. The logger will exclude l…ogs if the log event ID is on the provided list.
  • Prepare 9.3.0 release.

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

…ogs if the log event id is on the provided list.

Prepare 9.3.0 release.
@novalisdenahi novalisdenahi requested a review from a team as a code owner June 26, 2024 16:02
Copy link
Contributor

@adams85 adams85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a list of event ids to exclude, I would strongly consider adding some filter callback to the options (could be a lambda or interface). I think it would be a more flexible API because then we could pass the whole context of the log event (log level, event id, message, exception) to this callback, which would allow consumers to implement more complex pieces of filtering logic as well.

src/main/java/com/configcat/ConfigCatClient.java Outdated Show resolved Hide resolved
src/main/java/com/configcat/ConfigCatLogger.java Outdated Show resolved Hide resolved
src/main/java/com/configcat/ConfigCatLogger.java Outdated Show resolved Hide resolved
src/main/java/com/configcat/ConfigCatClient.java Outdated Show resolved Hide resolved
Copy link
Contributor

@adams85 adams85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

Copy link
Contributor

@adams85 adams85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this comment looks like outdated.

src/main/java/com/configcat/ConfigCatClient.java Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jul 2, 2024

@novalisdenahi novalisdenahi merged commit 803d045 into master Jul 4, 2024
8 checks passed
@novalisdenahi novalisdenahi deleted the log-exclude-option branch July 4, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants