add rbi-CDH: v1 #651
Open
add rbi-CDH: v1 #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zny666
requested review from
sameo,
jiangliu,
arronwy,
lumjjb,
jialez0 and
Xynnn007
as code owners
fitzthum
requested changes
Aug 5, 2024
There was a problem hiding this comment.
PR is missing the DCO sign-off. Please add.
Also, you are changing the permissions of every file in the repo. I don't think that is necessary.
See additional comments below.
Comment on lines
+8
to
+9
| sudo docker run -d --network host --name cdh-build1 rbi-cdh:v1 | ||
| sudo docker run -d --network host --name cdh-build2 rbi-cdh:v1 |
There was a problem hiding this comment.
You seem to be running the same container image (rbi-cdh:v1) twice. Later you check that these contain the same CDH binary. Since they are the same container, they will contain the same binary. This isn't a reproducible build.
There was a problem hiding this comment.
I think rbi-CDH is not the right place to put this. If you are adding an additional test, put it alongside the existing github workflows. If you are changing the makefile, try updating the existing makefile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加了基于镜像的构建，位于rbi-CDH文件夹，脚本在本地运行良好，目前缺少各种错误处理脚本。