Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for gateway api v2 #54

Merged
merged 19 commits into from
Aug 6, 2024
Merged

Add support for gateway api v2 #54

merged 19 commits into from
Aug 6, 2024

Conversation

achever1
Copy link
Contributor

No description provided.

@achever1 achever1 force-pushed the feat/gw_cli branch 4 times, most recently from 792358b to e31116f Compare July 17, 2024 13:06
@achever1 achever1 marked this pull request as ready for review July 26, 2024 07:38
@achever1 achever1 requested review from fteychene and strokyl July 26, 2024 07:38
strokyl
strokyl reviewed Jul 30, 2024
View reviewed changes
schema/default-schema.json Outdated Show resolved Hide resolved
strokyl
strokyl reviewed Jul 30, 2024
View reviewed changes
cmd/gateway_utils.go Outdated Show resolved Hide resolved
strokyl
strokyl requested changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@strokyl strokyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least I think we should:

  • have two json for default_kind of gw/console.
  • have a separate kind catalog in the code for gateway.

@strokyl strokyl merged commit 04d96e1 into main Aug 6, 2024
4 checks passed
@strokyl strokyl deleted the feat/gw_cli branch August 6, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fteychene fteychene fteychene approved these changes

@strokyl strokyl strokyl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achever1 @strokyl @fteychene