feat: add rattler_menuinst crate

Cargo.toml

@@ -157,6 +157,7 @@ trybuild = { version = "1.0.101" }
 typed-path = { version = "0.10.0" }
 url = { version = "2.5.4" }
 uuid = { version = "1.11.0", default-features = false }
+unicode-normalization = { version = "0.1.24" }
 walkdir = "2.5.0"
 windows-sys = { version = "0.59.0", default-features = false }
 zip = { version = "2.2.2", default-features = false }

crates/rattler/Cargo.toml

@@ -32,6 +32,7 @@ memchr = { workspace = true }
 memmap2 = { workspace = true }
 once_cell = { workspace = true }
 parking_lot = { workspace = true }
+rattler_menuinst = { path = "../rattler_menuinst", version = "0.1.0", default-features = false }
 rattler_cache = { path = "../rattler_cache", version = "0.3.0", default-features = false }
 rattler_conda_types = { path = "../rattler_conda_types", version = "0.29.6", default-features = false }
 rattler_digest = { path = "../rattler_digest", version = "1.0.4", default-features = false }

crates/rattler/src/install/driver.rs

@@ -1,13 +1,14 @@
 use std::{
     borrow::Borrow,
     collections::{HashMap, HashSet},
+    ffi::OsStr,
     path::{Path, PathBuf},
     sync::{Arc, Mutex, MutexGuard},
 };
 
 use indexmap::IndexSet;
 use itertools::Itertools;
-use rattler_conda_types::{prefix_record::PathType, PackageRecord, PrefixRecord};
+use rattler_conda_types::{prefix_record::PathType, PackageRecord, Platform, PrefixRecord};
 use simple_spawn_blocking::{tokio::run_blocking_task, Cancelled};
 use thiserror::Error;
 use tokio::sync::{AcquireError, OwnedSemaphorePermit, Semaphore};
@@ -155,18 +156,41 @@ impl InstallDriver {
         transaction: &Transaction<Old, New>,
         target_prefix: &Path,
     ) -> Result<Option<PrePostLinkResult>, PrePostLinkError> {
+        let mut result = None;
         if self.execute_link_scripts {
             match self.run_pre_unlink_scripts(transaction, target_prefix) {
                 Ok(res) => {
-                    return Ok(Some(res));
+                    result = Some(res);
                 }
                 Err(e) => {
                     tracing::error!("Error running pre-unlink scripts: {:?}", e);
                 }
             }
         }
 
-        Ok(None)
+        // For all packages that are removed, we need to remove menuinst entries as well
+        for record in transaction.removed_packages().map(Borrow::borrow) {
+            for path in record.paths_data.paths.iter() {
+                if path.relative_path.starts_with("Menu")
+                    && path.relative_path.extension() == Some(OsStr::new("json"))
+                {
+                    match rattler_menuinst::remove_menu_items(
+                        &target_prefix.join(&path.relative_path),
+                        target_prefix,
+                        target_prefix,
+                        Platform::current(),
+                        rattler_menuinst::MenuMode::User,
+                    ) {
+                        Ok(_) => {}
+                        Err(e) => {
+                            tracing::warn!("Failed to remove menu item: {}", e);
+                        }
+                    }
+                }
+            }
+        }
+
+        Ok(result)
     }
 
     /// Runs a blocking task that will execute on a separate thread. The task is
@@ -222,6 +246,25 @@ impl InstallDriver {
             None
         };
 
+        // find all files in `$PREFIX/Menu/*.json` and install them with `menuinst`
+        if let Ok(read_dir) = target_prefix.join("Menu").read_dir() {
+            for file in read_dir.flatten() {
+                let file = file.path();
+                if file.is_file() && file.extension().map_or(false, |ext| ext == "json") {
+                    rattler_menuinst::install_menuitems(
+                        &file,
+                        target_prefix,
+                        target_prefix,
+                        Platform::current(),
+                        rattler_menuinst::MenuMode::User,
+                    )
+                    .unwrap_or_else(|e| {
+                        tracing::warn!("Failed to install menu item: {} (ignored)", e);
+                    });
+                }
+            }
+        }
+
         Ok(PostProcessResult {
             post_link_result,
             clobbered_paths,

crates/rattler_conda_types/src/match_spec/mod.rs

@@ -716,4 +716,9 @@ mod tests {
             .collect::<Vec<String>>()
             .join("\n"));
     }
+
+    #[test]
+    fn test_size_stays_the_same() {
+        assert_eq!(std::mem::size_of::<MatchSpec>(), 464);
+    }
 }

crates/rattler_menuinst/Cargo.toml

@@ -0,0 +1,46 @@
+[package]
+name = "rattler_menuinst"
+version = "0.1.0"
+edition.workspace = true
+authors = ["Wolf Vollprecht <[email protected]>"]
+description = "Install menu entries for a Conda package"
+categories.workspace = true
+homepage.workspace = true
+repository.workspace = true
+license.workspace = true
+readme.workspace = true
+
+[dependencies]
+plist = { workspace = true }
+dirs = { workspace = true }
+serde = { workspace = true, features = ["derive"] }
+shlex = { workspace = true }
+serde_json = { workspace = true }
+tracing = { workspace = true }
+rattler_conda_types = { path = "../rattler_conda_types", default-features = false }
+rattler_shell = { path = "../rattler_shell", default-features = false }
+thiserror = { workspace = true }
+unicode-normalization = { workspace = true }
+regex = { workspace = true }
+tempfile = { workspace = true }
+fs-err = { workspace = true }
+which = "7.0.0"
+known-folders = "1.2.0"
+quick-xml = "0.37.1"
+chrono = { workspace = true, features = ["clock"] }
+configparser = { version = "3.1.0", features = ["indexmap"] }
+
+[target.'cfg(target_os = "windows")'.dependencies]
+windows = { version = "0.58", features = [
+    "Win32_System_Com",
+    "Win32_UI_Shell",
+    "Win32_System_Com_StructuredStorage",
+    "Win32_UI_Shell_PropertiesSystem",
+    "Win32_Storage_EnhancedStorage",
+    "Win32_Foundation",
+    "implement"
+]}
+winreg = "0.52.0"
+
+[dev-dependencies]
+insta = { workspace = true }

crates/rattler_menuinst/data/menuinst.default.json

@@ -0,0 +1,68 @@
+{
+  "id_": "https://schemas.conda.io/menuinst-1.schema.json",
+  "schema_": "https://json-schema.org/draft-07/schema",
+  "menu_name": "REQUIRED",
+  "menu_items": [
+    {
+      "name": "REQUIRED",
+      "description": "REQUIRED",
+      "command": [
+        "REQUIRED"
+      ],
+      "icon": null,
+      "precommand": null,
+      "precreate": null,
+      "working_dir": null,
+      "activate": true,
+      "terminal": false,
+      "platforms": {
+        "linux": {
+          "Categories": null,
+          "DBusActivatable": null,
+          "GenericName": null,
+          "Hidden": null,
+          "Implements": null,
+          "Keywords": null,
+          "MimeType": null,
+          "NoDisplay": null,
+          "NotShowIn": null,
+          "OnlyShowIn": null,
+          "PrefersNonDefaultGPU": null,
+          "StartupNotify": null,
+          "StartupWMClass": null,
+          "TryExec": null,
+          "glob_patterns": null
+        },
+        "osx": {
+          "CFBundleDisplayName": null,
+          "CFBundleIdentifier": null,
+          "CFBundleName": null,
+          "CFBundleSpokenName": null,
+          "CFBundleVersion": null,
+          "CFBundleURLTypes": null,
+          "CFBundleDocumentTypes": null,
+          "LSApplicationCategoryType": null,
+          "LSBackgroundOnly": null,
+          "LSEnvironment": null,
+          "LSMinimumSystemVersion": null,
+          "LSMultipleInstancesProhibited": null,
+          "LSRequiresNativeExecution": null,
+          "NSSupportsAutomaticGraphicsSwitching": null,
+          "UTExportedTypeDeclarations": null,
+          "UTImportedTypeDeclarations": null,
+          "entitlements": null,
+          "link_in_bundle": null,
+          "event_handler": null
+        },
+        "win": {
+          "desktop": true,
+          "quicklaunch": true,
+          "terminal_profile": null,
+          "url_protocols": null,
+          "file_extensions": null,
+          "app_user_model_id": null
+        }
+      }
+    }
+  ]
+}